Add build and signing (#1)#25
Merged
Merged
Conversation
Contributor
lukekim
commented
Apr 15, 2025
lukekim
commented
- Add code-signing release
* Add Pull Request action * Use cloud machines * Remove make * Revert "Remove make" This reverts commit 57d771a. * Remove make * Build on merge to trunk * Add code-signing release * Update path
lukekim
requested review from
Copilot and
sgrebnov
and removed request for
Copilot
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
.github/workflows/release.yml:15
- Verify that 'code-signing' is a valid runner label and available in your GitHub Actions environment. If it is a custom runner, ensure proper configuration to avoid unintended workflow failures.
runs-on: code-signing
.github/workflows/release.yml:28
- [nitpick] The step name 'Make Package (unsigned)' could be misleading since it only runs 'make package'. Consider renaming it to better reflect its purpose, such as 'Build unsigned package'.
- name: Make Package (unsigned)
sgrebnov
approved these changes
Apr 15, 2025
* Tweak * Tweak * Remove folder * Remove bash * Windows Updates * Build updates * Use hardcoded path * Try hardcoding * Tweaks for testing * Add powershell script * Use Powershell script * Add error checks * Test * Test * Fix the environment * Add upload step * Fix script * Fix * Fix * Use machines Java * Tweaks * Try storepass * Use http --------- Co-authored-by: Sergei Grebnov <sergei.grebnov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.